Changeset 42478 in webkit

Timestamp:

Apr 13, 2009 11:24:43 PM (15 years ago)

Author:

oliver@apple.com

Message:

BUG 25171: It should be possible to manually set the name of an anonymous function
<​https://bugs.webkit.org/show_bug.cgi?id=25171>

Submitted by Francisco Tolmasky <​francisco@280north.com>
Reviewed by Oliver Hunt.

This change adds the displayName property to functions, which when set overrides the
normal name when appearing in the console.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/profiler/Profiler.cpp (modified) (1 diff)
• JavaScriptCore/runtime/CommonIdentifiers.h (modified) (1 diff)
• JavaScriptCore/runtime/InternalFunction.cpp (modified) (1 diff)
• JavaScriptCore/runtime/InternalFunction.h (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/profiler/anonymous-functions-with-display-names-expected.txt (added)
• LayoutTests/fast/profiler/anonymous-functions-with-display-names.html (added)
• LayoutTests/fast/profiler/named-functions-with-display-names-expected.txt (added)
• LayoutTests/fast/profiler/named-functions-with-display-names.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 2009-04-13  Geoffrey Garen  <ggaren@apple.com>
 

trunk/JavaScriptCore/profiler/Profiler.cpp

@@ -149 +149 @@
 CallIdentifier createCallIdentifierFromFunctionImp(JSGlobalData* globalData, JSFunction* function)
 {
-    const UString& name = function->name(globalData);
+    const UString& name = function->ame(globalData);
     return CallIdentifier(name.isEmpty() ? AnonymousFunction : name, function->body()->sourceURL(), function->body()->lineNo());
 }

trunk/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -64 +64 @@
     macro(toString) \
     macro(UTC) \
-    macro(valueOf)
+    macro(valueOf) \
+    macro(displayName)
 
 namespace JSC {

trunk/JavaScriptCore/runtime/InternalFunction.cpp

@@ -49 +49 @@
 }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 } // namespace JSC

trunk/JavaScriptCore/runtime/InternalFunction.h

@@ -38 +38 @@
 
         const UString& name(JSGlobalData*);
+
+
 
         static PassRefPtr<Structure> createStructure(JSValuePtr proto) 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 2009-04-13  Darin Adler  <darin@apple.com>