| commit | 59fe7eadc17c215e09d2232c0c6e07705119f982 | [log] [tgz] |
|---|---|---|
| author | Alexander Maryanovsky <alexander.maryanovsky@jetbrains.com> | Fri Jan 13 23:16:14 2023 +0200 |
| committer | Alexander Maryanovsky <alexander.maryanovsky@jetbrains.com> | Wed Jan 18 16:24:28 2023 +0200 |
| tree | 7d298f8a9e20f8fc4505a26ea54fe97360fe2045 | |
| parent | 87ae7c95994a3a04dfc524775877e18f337e1efd [diff] |
Add ScrollState.viewportSize in order to support scrollbars. For a scrollbar to correctly size its "thumb" it needs to know the ratio between the size of the visible part of the scrolled content (viewport) and the size of the entire content. Additionally, to be able to scroll a "page" (when clicked on the track) it needs the size of the viewport. Unfortunately this information is not currently available in ScrollState. In our current, incorrect, implementation, the scrollbar assumes that its own size (e.g. height for a vertical scrollbar) is also the size of the viewport. This is correct most of the time, so it has went unnoticed until now. We considered several options to add this information: 1. Simply add a `viewportSize` property to ScrollState to indicate the visible size of the content. The size of the entire content can be calculated with `maxValue + viewportSize` (the case where the content is smaller than the viewport is irrelevant for a scrollbar). 2. Analogously to LazyListState add a `layoutInfo` property to ScrollState and put `viewportSize` in it. Possibly add `contentSize` there too. The latter would create the implicit dependency that `maxValue == max(0, contentSize - viewportSize)`. The first option is currently our favorite, due to its simplicity, and because we don't foresee more fields being added into the `ScrollableLayoutInfo` suggested in option 2. Test: unit tests Change-Id: I16e79d7b8a286fda98b535efcb457e66ade60751
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.
