Details
- Reviewers
Standard8 - Commits
- rMOZILLACENTRALa65344e02551: Bug 1880899 - add lint rule that prevents adding more browser.js globals…
- Bugzilla Bug ID
- 1880899
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Code analysis found 3 defects in diff 827654:
- 3 defects found by eslint (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 827654.
3 defects closed compared to the previous diff 827654.
If you see a problem in this automated review, please report it here.
| .eslintrc.js | ||
|---|---|---|
| 256–260 | I think not centralising it in the config is helpful in terms of being able to easily adopt it for other files, though I'd need to doublecheck that doing the linting on encountering Program works in that case (like does that node's processing by eslint get invoked before or after the file level comment?). However I'm a bit nervous someone would (accidentally or otherwise...) move or remove it and break it, which seems less likely with the eslint config. Really kind of on the fence on this. Are my concerns about the fragility of the inline comment warranted at all, @Standard8 / @mossop ? | |
| .eslintrc.js | ||
|---|---|---|
| 256–260 | Let's go with the config, it is probably safer, and if we feel it needs to change in the future, then we can do that. | |
It can be previewed for one week:
If you see a problem in this automated review, please report it here.