This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
Add new i3-like dynamic layout #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, but currently merging new features is problematic. This is because Bismuth is transitioning to C++ from TypeScript, because the latter keeps it hard to add some new features, that integrate Bismuth with the Plasma desktop. Given my schedule, I don't think it is possible to achieve the full C++ port in a reasonable time with me alone, so if you or somebody else wanted to help - it is appreciated. The tiling logic is a relatively isolated module, so it can be ported with relative ease. |
|
I see, thank you for your answer. I really want to help with that, but unfortunately I don't think I'll have the time for the months to come. When I get some more free time, I'll try to come back to this :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new layout similar to i3's (and sway's) behavior. If you don't know i3, the main difference with bismuth is that i3 doesn't have predefined layouts. You compose your layout as you go by splitting your screen in vertical and horizontal containers.
This is not a full implementation, more like an early draft to get your opinion. I tried implementing the change in the least intrusive way, but I had to make a few changes in the generic Engine code too.
To implement this layout, I had to keep track of windows in the layout itself. So there are two different states with the list of the windows: the WindowsStore, and the layout's list. This introduce some complexity, and potentially bugs if those states desync. I'm wondering if this really is the right approach, I'm starting to think we should aim for a bigger change in the core of bismuth to implement nested layouts (#93) to have more robust code and more features (the nesting itself). Feedback is welcome :)
Things left to implement
Breaking Changes
The first commit changes the behavior of bismuth regarding new windows. Instead of adding them at the end of the list, new windows are now added just next to the current one.
UI Changes
Test Plan
Not planned yet
Related Issues
Closes #182