Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added intlTelInput-jquery.min.js #55

Closed
wants to merge 1 commit into from

Conversation

i-panov
Copy link

@i-panov i-panov commented Oct 30, 2018

Fixes #54

@Borales Borales self-assigned this Oct 30, 2018
@i-panov
Copy link
Author

i-panov commented Oct 31, 2018

@Borales can you merge it?

@@ -18,6 +18,7 @@ class PhoneInputAsset extends AssetBundle
public $js = [
'build/js/utils.js',
'build/js/intlTelInput.min.js',
'build/js/intlTelInput-jquery.min.js',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-panov I believe since https://github.com/jackocnr/intl-tel-input made a "separate jQuery wrapped version" - we should replace build/js/intlTelInput.min.js with build/js/intlTelInput-jquery.min.js, right? I don't think we should be using both at once

Copy link
Author

@i-panov i-panov Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borales Perhaps you are right. I did not understand what js files are needed or not needed by this library. I just saw that when intlTelInput-jquery.min.js was connected everything worked. But since if you disable intlTelInput.min.js, nothing breaks (I checked), you can remove it. A new problem is in another - in one of the latest updates bower/intl-tel-input the file intlTelInput-jquery.min.js was missing. And now if I try to connect it, I get 404. You do not know what happened there? I see that it is in the github repository, but it is not downloaded out by a composer...

@a1inani
Copy link

a1inani commented Oct 15, 2019

@Borales can a newer release be created? This problem persists in the current new build, requiring manual changes to the file on each deployment

@Borales Borales closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants