-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donate your skin! #203
Comments
I'm nearly done with a skin matching the solarized dark color scheme. The last two things that are left is |
@DanielTrautmann You made a pretty skin! |
Well the red is the one that is specified by the solarized color scheme, so I used it. But I agree it doesn't look that good in this context. I will add the remaining things tomorrow. After that I can share the skin. I used the RGB values since iTerm2 on Mac works well with that and I'm not familiar with these ANSI color codes and termcolor didn't seem to work. |
You can find the 8bits ANSI colors here: https://en.wikipedia.org/wiki/ANSI_escape_code They're compatible with more terminals but are so limited it's hard to do anything pretty. It's OK to make a less compatible skin, we just have to tell it. |
Okay I've finished the work on the solarized dark skin. Using ANSI colors was not possible. The colors didn't match at all. My terminal (iTerm2) is configured to use the Solarized Dark color preset and I thought if I use the ANSI code, it would match the one from the terminal, but this is not the case at it seems. However, the RGB version works. I also changed the error color from red to orange, which looks a bit better. For How would you like the skin to be shared? |
I thought about posting it on https://dystroy.org/broot as text with pictures. If you have a better idea, it would be welcome. |
Done. See #213 |
Maybe is possible to generate automatically skins based on the base16 themes? |
Most modern terminals have (or should have in my humble opinion) |
Writing a terminal application makes you realize most terminals in use have very very low capabilities. RGB can't be the default. But I'm very OK with
I'd welcome beautiful complete skins. |
As someone having had a nightmare from a previous curses application, bad enough to never attempt one again, I agree. That said, It so happens that most terminals just use |
I'm not sure of what you're suggesting. Is it to have a RGB skin used by default when possible ? |
I'm saying that most terminals do actually understand RGB code fine, (See the list- gnome-terminal, xfce4-terminal, konsole are probably the 3 most popular terminal emulators and all 3 support RGB. (IMHO your target audience is likely to be using Termite and Alacritty, both of which support RGB too. So if you're wiilling to forgot supporting a few users, a lot of users might see beautiful skins 👍 |
But you can already use RGB skins, there's no need to drop users for that (who are far from "a few"). |
Hey, having such limited skin options when it comes to theming is a bit off-putting and one should have the luxury of time to invest into translating their color schemes into broot's configuration. Its a common pattern to have a base16 colorscheme as your primary and manage the looks in multiple targets at the same time. In case you're not familiar, you can build a mustache template and produce a colorscheme in the broot format from a base16 scheme. You can have a look at the main base16 repository which describes and contains both color schemes as well as templates if you'd like to look into some examples. In few words building a good template can produce a plethora of schemes including those that people are most likely looking for already and give the opportunity for others that run custom schemes adapt broot into their workflow in a blink of an eye. Couple of ways to manage your configuration |
I was looking at broots theming, and I think an ANSI theme would be good to add: https://jeffkreeftmeijer.com/vim-16-color/. It's usually the default for shell tooling and allows the application to adapt automatically to the terminal's theme. I use that approach, that way you don't have to faff around with setting a matching theme for each terminal app. You just set a theme for your terminal emulator and you're done. It doesn't seem like broot currently ships with such a theme, not for syntax or for broot itself. Is that correct? |
Yes it's correct. Such a theme isn't trivially done if you want it to render pleasantly whatever the displayed data. |
I've taken a look at it. Whilst I wouldn't be opposed to creating and submitting an 8 bit ANSI theme, it seems like https://github.com/trishume/syntect doesn't have a theme that restricts itself to 8 bit ANSI. So whilst broot would then look good, the syntect syntax highlighting would still be off. It's too bad really, because I do like the ergonomics and idea behind broot. Let me know if syntect supports it in the future, I might be open to contributing a theme for broot then. |
Thanks for the quick feedback. In order to finish this I'd prefer to define colors for these remaining items:
But I've not been able to find where they're used in the UI. Could you point me to where I can find them? |
Hum... A documentation of all skin entries would be welcome but would require some time. The "purpose" things are used in the status line |
Thanks. I've added the remaining colors (where possible) and created a PR. |
I'd like to have a list of skins to propose to users.
So if you have a skin you find good (a complete one, not just two colors changed), please answer this issue with the toml and a screenshot (or several ones).
The text was updated successfully, but these errors were encountered: