Replace zlib with zlib-ng #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kring zlib-ng is available in VCPKG as well. Should I incorporate these changes into my VCPKG PR? |
|
@jherico we haven't reviewed this yet, but I suspect it should be a pretty decent win with no downside, so I think yes, we'll want it in the vcpkg PR eventually. I don't want to create work for you when we haven't even given you the review we owe you yet, though! |
|
Thanks @azrogers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707.
This change replaces the dependency on zlib with zlib-ng. This is a fork of zlib with improved performance, including support for hardware acceleration. It also adds tests to the CesiumUtility Gunzip implementation.