Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Lock colors to 1.4.0" #10003

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Revert "Lock colors to 1.4.0" #10003

merged 1 commit into from
Jan 10, 2022

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Jan 10, 2022 •
edited
Loading

Fixes #10002

Reverts #10001 after colors v1.4.1 was removed from npm.
@ebogo1 ebogo1 requested a review from ggetz January 10, 2022 21:02
@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
@ggetz
Copy link
Contributor

ggetz commented Jan 10, 2022

Awesome, thanks @ebogo1 !
@ggetz ggetz merged commit fe9efc7 into main Jan 10, 2022
@ggetz ggetz deleted the revert-10001-colors-1.4.0 branch January 10, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@ebogo1 @cesium-concierge @ggetz