Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Particle System Weather Sandcastle code needs cleanup #10038

Closed
ggetz opened this issue Jan 26, 2022 · 0 comments · Fixed by #10045
Closed

Particle System Weather Sandcastle code needs cleanup #10038

ggetz opened this issue Jan 26, 2022 · 0 comments · Fixed by #10045
Labels
cleanup good first issue An opportunity for first time contributors

Comments

@ggetz
Copy link
Contributor

ggetz commented Jan 26, 2022

The "Particle System Weather" is structured in such a way that we need to disable the prefer-const rule to allow it to work as is. Really, the code needs to be restructured in such a way that disabling the rule is not necessary.

(See #10026 (comment))
@ggetz ggetz added cleanup good first issue An opportunity for first time contributors labels Jan 26, 2022
@srothst1 srothst1 mentioned this issue Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue An opportunity for first time contributors
1 participant
@ggetz