Unify cesium.com deploy #10839
Merged
Unify cesium.com deploy #10839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
sanjeetsuhag
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Thanks @ggetz, this will be a great QoL change around release time.
|
Thanks @sanjeetsuhag! This should be ready fro another look. |
|
@ggetz When running locally, the built version of CesiumViewer loads, but cannot correctly load all static assets. |
|
Good catch @sanjeetsuhag-
|
sanjeetsuhag
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a fair amount of deploy code that lives only in the
cesium.combranch. Thecesium.combranch is the "production" branch; When we push to it as part of the release process, travis CI will deploy files to the website for use in Sandcastle, documentation, cesium viewer, and a list of releases.However, due to this separate deployment code across branches, it can become a chore to merge in
maingiven any updates to.travis.ymlor the gulpfile such as when updating dev packages. This PR seeks to unify the logic as much as possible, pulling in the custom deploy logic from that branch and conditionally running it based on Travis environment variables.You can test the "production" paths locally by setting a local
TRAVIS_BRANCHenvironment variable to"cesium.com".travis.yml, moving any complex logic to a script, as recommended per the travis CI documentationscriptstotravisto be consistant with our other reposgulpfile.jssuch that it should be the same in both branches. There are now conditional paths where the differences were, which are run only in travis when the branch name matchescesium.com.