Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup npm script names #10313

Closed
ptrgags opened this issue Apr 21, 2022 · 0 comments · Fixed by #10583
Closed

Cleanup npm script names #10313

ptrgags opened this issue Apr 21, 2022 · 0 comments · Fixed by #10583
Labels
cleanup good first issue An opportunity for first time contributors

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Apr 21, 2022

Looking through the scripts in package.json, a lot of the tasks have inconsistent naming or have misleading names

To point out a few issues:

  • some tasks use kebab-case (e.g. prettier-check) while others use camelCase (e.g. buildApps). We should pick a consistent style. (Personally I find kebab-case easier to type on the command line)
  • generateDocumentation seems needlessly long, maybe build-docs?
  • release makes me think ":warning: this is a command to publish the code to some server, use with care! :warning:" when the task just builds the release version of Cesium locally. Perhaps build-release?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue An opportunity for first time contributors
2 participants
@ggetz @ptrgags