Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Source/ThirdParty" imports #10568

Closed
ggetz opened this issue Jul 19, 2022 · 1 comment
Closed

Refactor "Source/ThirdParty" imports #10568

ggetz opened this issue Jul 19, 2022 · 1 comment

Comments

@ggetz
Copy link
Contributor

ggetz commented Jul 19, 2022

Modules which are simply imported and exported in Source/ThirdParty are not strictly needed now that we no longer need to package them ahead of time for development, and most likely should not be exported from Cesium.js.

They should be removed, and anywhere in the code which relies on these files should instead require the node module directly.

@ggetz
Copy link
Contributor Author

ggetz commented Aug 18, 2022

Finished out thanks to @nshen!

@ggetz ggetz closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant