Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sandcastle examples to 3DTiles 1.1 #11692

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Update sandcastle examples to 3DTiles 1.1 #11692

merged 4 commits into from
Dec 13, 2023

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Dec 12, 2023 •
edited
Loading

Description

Update the Sandcastle examples under 3DTiles Next to 3DTiles 1.1 including the assets in ion. Also completely removes references to 3DTiles Next in Sandcastle

Issue number and link

Fixes #11668

Testing plan

  • Load Sandcastle locally (npm start)
  • Load each of the examples below in the 3DTiles category and verify they work as expected
    • 3D Tiles 1.1 CDB Yemen
    • 3D Tiles 1.1 Photogrammetry
    • 3D Tiles 1.1 Photogrammetry Classification
    • 3D Tiles 1.1 S2 Globe
    • Custom Shaders 3D Tiles
      • This one uses an Asset Depot asset which will need to be updated as part of a separate effort
    • Custom Shaders Models
    • Custom Shaders Property Textures

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistant code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code
ggetz
ggetz reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is looking good! Just one small suggestion.
Apps/Sandcastle/gallery/3D Tiles 1.1 CDB Yemen.html Outdated Show resolved Hide resolved
@jjspace
Copy link
Contributor Author

jjspace commented Dec 12, 2023

@ggetz Updated for the typo

Also updated the Yemen assets again after talking with @lilleyse
@ggetz
Copy link
Contributor

ggetz commented Dec 12, 2023

Also updated the Yemen assets again

What was the issue the first go-around?
@ggetz ggetz merged commit 8bff099 into main Dec 13, 2023
9 checks passed
@ggetz ggetz deleted the update-sandcastle-3dtiles-next branch December 13, 2023 15:48
@jjspace
Copy link
Contributor Author

jjspace commented Dec 13, 2023

@ggetz as discussed in person the one I upgraded myself was still using the legacy extensions for some models (EXT_feature_metadata). While it worked in CesiumJS there was some concern that it wouldn't in other Cesium Native runtimes.
Even if it would've worked fine updating to the "correctly" generated assets provided by Sean was a small change and easy to make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jjspace @ggetz