Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KmlDataSource unsupportedNode event not raised for all unsupported features #4190

Open
hpinkos opened this issue Aug 10, 2016 · 2 comments
Open

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Aug 10, 2016

KmlDataSource has an event called unsupportedNodeEvent that is supposed to be raised whenever the data source finds an unsupported type. However, from what I can tell from the code, it is currently only raised when the PhotoOverlay, ScreenOverlay and Tour tags are used. There are console.logs all over the place for other unsupported features, but the event is not raised in those other places.

Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/Snsdh3Z_wX0

@borisgontar
Copy link

Any chance to get this fixed sooner than later? Getting FeatureData is very important for us...

Thanks, Boris.

@mramato
Copy link
Contributor

mramato commented Sep 2, 2016

Hi @borisgontar, we'd be happy to take a pull request here. The changes should be straightforward and all of the code is isolated to just KmlDataSource.js so we should be able to merge it pretty quickly. You'll need to fill out a CLA as mentioned in https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md

Otherwise, I'm sure we'll get to this within a few months, once some time frees up from other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment