Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with JulianDates in distant past or far future. #4597

Open
mramato opened this issue Nov 3, 2016 · 0 comments
Open

Problems with JulianDates in distant past or far future. #4597

mramato opened this issue Nov 3, 2016 · 0 comments

Comments

@mramato
Copy link
Contributor

mramato commented Nov 3, 2016

We currently don't define minimum or maximum values for JulianDateinstances. I'm actually pretty sure that minimum and maximum values don't actually exist and the date itself is always valid (obviously still limited by JavaScript Number bounds).

Where we run into problems is trying to actually format really old or far future dates as gregorian strings. For example, zooming out really far on the timeline starts to show undefined labels for dates before 4713 BCE. This may only be a problem for Timeline and Animation, I'm not sure if we display times anywhere else.

We should test our conversion to Gregorian for the far off dates and see if it's the conversion itself that presents a problem or simply how we turn that into a formatted string. I don't have a good solution for now, and I doubt this is a pressing issue anytime soon, but I wanted to write up the issue so that we don't forget about it.

Found while working on #4595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants