Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GEE test coverage #5348

Closed
pjcozzi opened this issue May 22, 2017 · 5 comments
Closed

Improve GEE test coverage #5348

pjcozzi opened this issue May 22, 2017 · 5 comments
Labels
category - terrain and imagery cleanup good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented May 22, 2017

These files have some of the lowest coverage in Cesium:

image

Perhaps it is possible to create stubs to cover more of the code.

@pjcozzi pjcozzi added good first issue An opportunity for first time contributors cleanup labels May 22, 2017
@pjcozzi
Copy link
Contributor Author

pjcozzi commented May 22, 2017

And these:

image

@mramato
Copy link
Contributor

mramato commented May 22, 2017

Part of the issue is that there is a large amount of generated code from the protocol buffer stuff, it would make sense to add whatever special comments we need to instruct coverage to ignore those junks of code.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented May 22, 2017

Sounds good. Related: if it is not a huge amount of work, I am also into looking at other coverage tools that we can run as part of CI.

@mramato
Copy link
Contributor

mramato commented May 22, 2017

Switching to istanbul has been the plan for a while and is what we use in all of our other projects.. The problem is karma is lagging behind istanbul versions and we need the newer versions to actually be able to test Cesium (because of it's size). It might be easy to just use istanbul directly, but I need to look more into it.

@ggetz
Copy link
Contributor

ggetz commented Apr 13, 2023

This is unlikely to become a priority anytime soon. We'd still happily accept a PR addressing this issue. But tracking this isn't particularly useful because of its low priority, so I will close it. Thanks!

@ggetz ggetz closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - terrain and imagery cleanup good first issue An opportunity for first time contributors
3 participants