Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable jasmine random test ordering and fix broken tests #6385

Open
mramato opened this issue Mar 28, 2018 · 0 comments
Open

Enable jasmine random test ordering and fix broken tests #6385

mramato opened this issue Mar 28, 2018 · 0 comments
Labels
category - tooling cleanup

Comments

@mramato
Copy link
Contributor

mramato commented Mar 28, 2018

#6383 upgraded Jasmine which includes random testing ordering as the default. This is desired because it creates more robust, standalone unit tests and make sure unit tests don't conflict with each other. Unfortunately, Cesium's current unit tests have lots of this going on. Someone needs to re-enable the flag in karma.conf.js and fix any test failures exposed by repeatedly running npm run test. (this doesn't affect our ancient copy of jasmine that runs in the browser)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - tooling cleanup
1 participant
@mramato