Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wasm workaround for Edge #10390

Merged
merged 2 commits into from
May 18, 2022
Merged

Remove wasm workaround for Edge #10390

merged 2 commits into from
May 18, 2022

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 18, 2022

Fixes #6542

Removes the exception for Edge for web assembly module support.

@sanjeetsuhag Can you very this in Edge? You should be able to load a Draco module such as in https://sandcastle.cesium.com/?src=3D%20Models.html without error.
@ggetz ggetz requested a review from sanjeetsuhag May 18, 2022 18:13
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
sanjeetsuhag
sanjeetsuhag approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz. I tested this on my Windows 10 with Edge Version 101.0.1210.47 and both of the 3D Models and ModelExperimental Sandcastles that use Draco worked!
@sanjeetsuhag sanjeetsuhag merged commit 82465d5 into main May 18, 2022
@sanjeetsuhag sanjeetsuhag deleted the remove-wasm-wrkaround branch May 18, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@ggetz @cesium-concierge @sanjeetsuhag