Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression 'evaluate' functions should not pass frameState paramter #6874

Closed
OmarShehata opened this issue Aug 2, 2018 · 3 comments
Closed
Labels

Comments

@OmarShehata
Copy link
Contributor

In the Cesium.StyleExpression page, the frameState description isn't very descriptive. Clicking on it to find out more goes to:

https://cesiumjs.org/Cesium/Build/Documentation/FrameState.html

Which is a 404.

@mramato
Copy link
Contributor

mramato commented Aug 2, 2018

FrameState is a private class, so it's not supposed to be documented or mentioned in the docs for that matter. So the problem here is in StyleExpression, not FrameState

@lilleyse
Copy link
Contributor

lilleyse commented Aug 2, 2018

Good catch @OmarShehata. FrameState is meant to be private so this is more a problem with Expression. Looking at it closer Expression doesn't actually use the frame state... maybe it once did but has since changed. Do you want to open a PR that removes the frameState parameter throughout Expression, ConditionsExpression, StyleExpression and anything that calls evaluate/evaluateColor?

@ggetz ggetz added the cleanup label Aug 2, 2018
@ggetz ggetz changed the title Missing docs for frameState Aug 2, 2018
@ggetz
Copy link
Contributor

ggetz commented Apr 12, 2023

Fixed in #6890

@ggetz ggetz closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants