Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Tiles - clean up underscored variables #7246

Open
lilleyse opened this issue Nov 7, 2018 · 0 comments
Open

3D Tiles - clean up underscored variables #7246

lilleyse opened this issue Nov 7, 2018 · 0 comments
Labels
category - 3d tiles cleanup

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Nov 7, 2018

3D Tiles files often use underscored private variables of other 3D Tiles files. One example is Cesium3DTilesetTraversal accessing tileset._selectedTiles and tileset._requestedTiles. Instead these should either be non-underscored private properties, functions, or part of a separate shared class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - 3d tiles cleanup
2 participants
@pjcozzi @lilleyse