Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make point cloud attenuation tests less fragile #7407

Open
lilleyse opened this issue Dec 12, 2018 · 0 comments
Open

Make point cloud attenuation tests less fragile #7407

lilleyse opened this issue Dec 12, 2018 · 0 comments
Labels
cleanup

Comments

@lilleyse
Copy link
Contributor

See @likangning93's comment in #7235:

Can confirm the fix as well, but the problem is more that the underlying spec is fragile, which is my fault from when these were written... the "reference" noAttenuationPixelCount value is hardcoded when it should probably be computed before any specs are run instead.

Maybe then we won't have to tune parameters to get this to pass both on Linux and Windows?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup
1 participant
@lilleyse