Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should not modify window.devicePixelRatio #8130

Closed
OmarShehata opened this issue Sep 3, 2019 · 3 comments
Closed

Tests should not modify window.devicePixelRatio #8130

OmarShehata opened this issue Sep 3, 2019 · 3 comments
Labels
cleanup test failure

Comments

@OmarShehata
Copy link
Contributor

OmarShehata commented Sep 3, 2019 •
edited
Loading

Our unit tests can't run in IE11 anymore after this PR #8083 (comment) which modifies the window.devicePixelRatio to ensure consistent unit test results on all devices.

The spec says that this property should be read-only, and it seems that only IE11 has an issue with this. It would be a good idea to revert this change and ensure our unit tests are consistent across different device pixel ratios.
@OmarShehata
Copy link
Contributor Author

I actually can't seem to run IE11 tests anymore, I don't get the SCRIPT5045: Assignment to read-only properties is not allowed in strict mode error. Just a blank screen.

My IE version is 11.719.18362.0.

I tested on a few versions back too, same behavior:

Anyone else seeing this?
@mramato
Copy link
Contributor

mramato commented Apr 1, 2020

I can check on my personal laptop later tonight, but it may be time to stop worrying about running unit tests in IE11 and just switch to IE11 smoke screen testing.
@ggetz
Copy link
Contributor

ggetz commented Jan 27, 2022

Closing since IE11 support has been dropped.
@ggetz ggetz closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup test failure
3 participants
@mramato @OmarShehata @ggetz