Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive interface #8909

Open
mramato opened this issue Jun 3, 2020 · 0 comments
Open

Primitive interface #8909

mramato opened this issue Jun 3, 2020 · 0 comments
Labels
category - doc category - graphics category - typescript cleanup

Comments

@mramato
Copy link
Contributor

mramato commented Jun 3, 2020

We actually don't have a concrete interface definition for primitives, i.e. things we store inside of PrimitiveCollection. It's simply documented everywhere as Object. What's even worse is that we have a Primitive class that renders geometry, but is not the base class or interface for all "primitives". Why we didn't name it GeometryPrimitive I'm not sure.

It would be great to clean up our own terminology here and define a base primitive interface so that we can use it in JSDoc and TypeScript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - doc category - graphics category - typescript cleanup
1 participant
@mramato