Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Draco quantization #9847

Closed
ebogo1 opened this issue Oct 1, 2021 · 2 comments · Fixed by #10126
Closed

Re-enable Draco quantization #9847

ebogo1 opened this issue Oct 1, 2021 · 2 comments · Fixed by #10126

Comments

@ebogo1
Copy link
Contributor

ebogo1 commented Oct 1, 2021

After #9841 gets merged, we will no longer quantize any attributes in the Draco worker. Some immediate tech debt from this PR:

  • This is a temporary workaround while we switch to the draco3d npm module, but it should be doable to at least get some quantization benefits by packing compressed attributes into 16 bits. In the PR, c9ac980 has some progress towards getting the math to work in the shader but has inconsistent results with different models (i.e. with Specs/Data/Models/DracoCompression/BoxVertexColorsDracoRGBA.gltf Draco returns a null pointer even on the "NORMAL" attribute, which is unexpected).
  • Some specs related to quantization were changed or deleted. These two commits should be reverted once quantization is added back: 1a3b697, 97c186c

Since this is a sizable regression, we should fix as much as we can in main ASAP and consider a follow-up 1.86.1 release.

related: #9787

@ebogo1
Copy link
Contributor Author

ebogo1 commented Oct 29, 2021

Update: most of the specs are now back in main after #9904 got merged. The specs for PointCloud3DTileContentSpec.js are the only ones left, and should be added in once the Draco issue is fixed.

@ebogo1
Copy link
Contributor Author

ebogo1 commented Nov 1, 2021

After #9908 is merged, all the specs will have been added back in. Once the Draco bug is fixed in the next release and we update the Draco version in CesiumJS, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant