Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debugShowBoundingSpheres option to Cesium3DTileset? #9996

Open
ptrgags opened this issue Jan 7, 2022 · 2 comments
Open

Add a debugShowBoundingSpheres option to Cesium3DTileset? #9996

ptrgags opened this issue Jan 7, 2022 · 2 comments

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Jan 7, 2022

When working on ModelExpeirimental, often I want to see not just the tile bounding volumes, but the draw command bounding volumes for debugging purposes.

For individual models, this can be done with the debugShowBoundingVolume option, which just sets the same property on each DrawCommand

For 3D Tiles, we already have tileset.debugShowBoundingVolume, but adding a debugShowBoundingSpheres or debugShowDrawCommandBounds option might be helpful here. Though this would require updating every type of Cesium3DTileContent.

Another option is to only support this flag for tilesets that use ModelExperimental for now (and mark it as an experimental parameter)

Any thoughts @sanjeetsuhag @lilleyse?

@sanjeetsuhag
Copy link
Contributor

@ptrgags I like this suggestion and it has been something I find lacking in the current API too. In terms of naming, maybe could use showBoundingVolume and showPrimitiveBoundingVolumes.

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 7, 2022

I don't think showPrimitiveBoundingVolumes is a great idea, as it may cause confusion with the Primitive interface (and Cesium3DTileset implements this interface). From a user perspective, "primitive" means anything renderable, not glTF primitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants