Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin settings regression with 6.2.0-RC1: only one settings without name is possible #6466

Closed
JohnXLivingston opened this issue Jul 5, 2024 · 4 comments
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor

Comments

@JohnXLivingston
Copy link
Contributor

JohnXLivingston commented Jul 5, 2024

Describe the current behavior

v6.2.0-RC1 comes with: "Add ability to register the same setting multiple times to replace the old one #6357 & 1bfb791e0"

This feature introduce a regression with settings that have no name.

For example, in the livechat plugin, i have multiple "settings" without name. There are in fact placeholders for some html markup. Here is an example:

 registerSetting({
    type: 'html',
    private: true,
    descriptionHTML: loc('important_note_title')
  })
  registerSetting({
    type: 'html',
    private: true,
    descriptionHTML: loc('important_note_text')
  })
  registerSetting({
    type: 'html',
    private: true,
    descriptionHTML: loc('diagnostic')
  })

With v6.2.0-RC1, these settings cancel each others, and only the last one remains.

Steps to reproduce

  1. use the livechat plugin
  2. go the the plugin settings page
  3. see that there are many missing labels. For example the "diagnostic" button is missing (check screenshots)

With v6.1.0:

image

With 6.2.0-RC1:

image

Describe the expected behavior

Settings with no name should not cancel each others.

Additional information

  • PeerTube instance:
    • Version: v6.2.0-RC1
@Chocobozzz Chocobozzz added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development labels Jul 11, 2024
@Chocobozzz
Copy link
Owner

Thanks, fixed by c5de5ef

@JohnXLivingston
Copy link
Contributor Author

Do you plan another RC before the stable 6.2.0?

@Chocobozzz
Copy link
Owner

No it's not planned but I think you can try the nightly build as the develop branch is the same as release/6.2.0

@JohnXLivingston
Copy link
Contributor Author

The question was not just about this issues. It was just to know. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor
2 participants