Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Make samples explicit and brief speed guide #489

Open
MartinSmeyer opened this issue Feb 18, 2022 · 0 comments
Open

[FEATURE]: Make samples explicit and brief speed guide #489

MartinSmeyer opened this issue Feb 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@MartinSmeyer
Copy link
Member

Is your feature request related to a problem? Please describe.
Required samples are highly scene dependent. We have hidden default values that often take unnecessarily long.

Describe the solution you'd like
We should make the samples explicit in examples again so that users have guidelines and the option to iterate faster.

Describe alternatives you've considered
A quickmode option. Or low default amount of samples, but this might lead to smoothed high-frequency artifacts of the denoiser depending on the scene. We don't want to assume that this is okay for every learning task even though it is for some.

@MartinSmeyer MartinSmeyer added the enhancement New feature or request label Feb 18, 2022
@MartinSmeyer MartinSmeyer self-assigned this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant