Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psql test cases #334

Open
yilinxia opened this issue Jun 20, 2024 · 2 comments
Open

psql test cases #334

yilinxia opened this issue Jun 20, 2024 · 2 comments

Comments

@yilinxia
Copy link
Contributor

psql tests have been used to help implement duckdb. This issue aims to record all test related issues

  1. For test psql_arg_min_max_k_test.l, it should be Test(opt: "Min", arg_opt: TestArgMin(), arg_opt_k: TestArgMinK()); instead of Test(opt: "Max", arg_opt: TestArgMin(), arg_opt_k: TestArgMinK()); for the second rule
@EvgSkv
Copy link
Owner

EvgSkv commented Jun 20, 2024

Thanks for reporting! Fixed it.
@yilinxia
Copy link
Contributor Author

  1. DuckDB is using True and False for Boolean instead of 0 and 1. When running the test psql_bool_test, we need ensure that it is comparable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@yilinxia @EvgSkv