Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exit Codes #88

Open
tay1orjones opened this issue Apr 19, 2017 · 1 comment
Open

Add Exit Codes #88

tay1orjones opened this issue Apr 19, 2017 · 1 comment

Comments

@tay1orjones
Copy link

Hi, I'm interested in adding a step to my Travis CI production deployment process that verifies that we have all translations needed and no conflicting IDs. If there are issues, the deployment should be halted.

This currently isn't possible, as manageTranslations always exits with success code 0. If there are conflicting IDs or untranslated keys, it still exits with a success code 0. Ideally, this would return 1 in those cases. With proper exit codes, CI tooling would be able to catch these issues upstream before a production deployment.

I think it would be beneficial for this to be the default behavior, although it could also be set behind a flag of some sort. Thoughts?
@GertjanReynaert
Copy link
Owner

Interesting idea, mind giving it a try in a pr?
@tay1orjones tay1orjones mentioned this issue May 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@tay1orjones @GertjanReynaert