Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImUnsortedMap should refine return type of ImMap.assoc(Map.Entry) #13

Closed
pniederw opened this issue Sep 13, 2016 · 1 comment
Closed

ImUnsortedMap should refine return type of ImMap.assoc(Map.Entry) #13

pniederw opened this issue Sep 13, 2016 · 1 comment
Labels
bug

Comments

@pniederw
Copy link

It does so for assoc(K, V), but not for assoc(Map.Entry<K, V>).
@GlenKPeterson
Copy link
Owner

Fixed in 2.0.9. I think the root cause of the issue was not doing 100% test coverage on the new code. If I had, I would have written sub-classes as part of the test. I have 100% coverage on every file I touched in this release. I'll do that probably fix the coverage of the other interfaces this weekend unless you report more bugs.

2016-09-13 Release 2.0.9:

  • Fixed return type of ImUnsortedMap and MutableUnsortedMap.assoc(Map.Entry)
  • Made ImUnsortedSet use MutableUnsortedSet's implementation of union() instead of the other way around.
  • Added tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
2 participants
@pniederw @GlenKPeterson