Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unmodMap/Set/List/SortedMap/SortedSet methods and Unmod classes in FunctionUtils? #18

Closed
GlenKPeterson opened this issue May 8, 2017 · 1 comment
Labels

Comments

@GlenKPeterson
Copy link
Owner

GlenKPeterson commented May 8, 2017

I'm talking about the wrapper classes, empty unmodifiable constructors and wrapper methods in FunctionalUtils. They seemed like a step in the right direction before incorporating the persistent collections from Clojure.

A year or two after adding the Clojure collections, I have removed all usages from client code. Instead I always use the data definition shortcuts in StaticImports like vec(...), set(...), etc., or xform(oldCollection).

People like that Paguro is small (less than 250K). I don't want to keep code that no-one is using when there are better ways of doing those things. Without that code, Paguro currently goes from 229,935 to 218,672 bytes which is 11K or about 5% difference. What do you think about eliminating those for Paguro 3.0?

@GlenKPeterson GlenKPeterson changed the title Are people using the unmodMap/Set/List/SortedMap/SortedSet methods or Unmod classes in FunctionUtils? May 8, 2017
@GlenKPeterson
Copy link
Owner Author

No-one responded, so I eliminated these wrappers in the 3.0 release which is on the RRB branch and ready to try out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant