Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface removed LCP element in report #11629

Open
patrickhulce opened this issue Nov 4, 2020 · 4 comments
Open

Surface removed LCP element in report #11629

patrickhulce opened this issue Nov 4, 2020 · 4 comments
Labels

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented Nov 4, 2020

Summary
Most of this discussion is happening in chat, but filing an issue so we don't forget. ref #11625 (comment)

LCP changed in m88 to now include removed elements. When this happens and there's a GC we can't find the LCP element anymore and the audit gets marked as not applicable. At that time we may also optionally consider removing _maxChromiumMilestone support from smoke tests.

@paulirish
Copy link
Member

in the future there may be more dedicated protocol support: events issued with node ids as they happen.

for now, we have to work around this ourselves:

  • set up a perfObserver
    • perhaps just having it with a reference prevents the node from being GC'd
    • if not, then we'll need to report it back from there in ~realtime.
@adamraine
Copy link
Member

Support was added but this boi is ancient? Do we still want this?

@paulirish
Copy link
Member

LargestImagePaint::Candidate is available and gives us image URL and coordinates. But doesn't help on the GC front.

The new CDP events in the above crbug give us the nodes at runtime. We can collect their nodeDetails as those events come in to ensure they're not GC'd before the TraceElements gatherer runs. For this to be worth it, we'd probably have to collect these nodeDetails right when the events come in. But... overhead is unknown and that may be unwise.

Something to look into, especially if we see this problem happening often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants