-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface removed LCP element in report #11629
Comments
in the future there may be more dedicated protocol support: events issued with node ids as they happen. for now, we have to work around this ourselves:
|
1138441 - Add Core Web Vitals metrics to Performance.GetMetrics results - chromium tracks the protocol support |
Support was added but this boi is ancient? Do we still want this? |
LargestImagePaint::Candidate is available and gives us image URL and coordinates. But doesn't help on the GC front. The new CDP events in the above crbug give us the nodes at runtime. We can collect their nodeDetails as those events come in to ensure they're not GC'd before the TraceElements gatherer runs. For this to be worth it, we'd probably have to collect these nodeDetails right when the events come in. But... overhead is unknown and that may be unwise. Something to look into, especially if we see this problem happening often. |
Summary
Most of this discussion is happening in chat, but filing an issue so we don't forget. ref #11625 (comment)
LCP changed in m88 to now include removed elements. When this happens and there's a GC we can't find the LCP element anymore and the audit gets marked as not applicable. At that time we may also optionally consider removing
_maxChromiumMilestone
support from smoke tests.The text was updated successfully, but these errors were encountered: