Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lantern EIL+TBT should use internally consistent FCP/TTI estimates #11677

Open
patrickhulce opened this issue Nov 17, 2020 · 1 comment
Open

Lantern EIL+TBT should use internally consistent FCP/TTI estimates #11677

patrickhulce opened this issue Nov 17, 2020 · 1 comment
Labels
P2 simulation / lantern

Comments

@patrickhulce
Copy link
Collaborator

Summary
Currently in the optimistic/pessimistic lantern estimates for EIL and TBT we use the timing data computed by the FCP/FMP/TTI metric simulations as cutoffs but this leads to internally inconsistent data when the graphs are slightly different in EIL/TBT (e.g. TBT's graph has a TTI of 3.2s but the timing from the pessimistic simulation was 3.1s so we ignore the last 100ms of blocking time)

We should explore using the nodes of FCP that exist in EIL/TBT graphs and using those times within our EIL/TBT simulation results computation.

Discovered as part of #11666
@paulirish
Copy link
Member

paulirish commented Jan 24, 2023 •
edited
Loading

EIL part is probably obsolete now.

Related to the FCP-can-be-faster-than-TTFB issue.

Also related: should TBT not be dependent on TTI.

More useful to extract metrics from the graph, rather than give-me-the-endTime-of-the-graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 simulation / lantern
4 participants
@paulirish @patrickhulce @adamraine @devtools-bot