Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL attribution in LH Report #15008

Open
alexnj opened this issue Apr 22, 2023 · 1 comment
Open

Add URL attribution in LH Report #15008

alexnj opened this issue Apr 22, 2023 · 1 comment

Comments

@alexnj
Copy link
Member

alexnj commented Apr 22, 2023

With 10.1, we have all URLs classified against their responsible entities. It's now easy to identify a 1P/3P URL and understand who it belongs to. It would be good to provide further visibility into who "invited" a URL/entity in — essentially bringing in the full dependency information.

I'm visualizing this as a tooltip on any report URL. We could use dependency graph computed audit / initiator to find the parent of a URL, and expose it in LHR as a Record<url:string, parent:number> (or a minimum-prefix Trie structure if the URL payload increase is a concern).

PS: My mental model around this is: In 10.1 we added the answer to "Who are all in my party?". This should help answer better the question, "Who gave this URL/entity the ticket in?". Since this information could benefit attribution of all URLs and not just 3Ps, it might be better implemented as a report-wide implementation.

@connorjclark
Copy link
Collaborator

connorjclark commented Apr 24, 2023

or a minimum-prefix Trie structure if the URL payload increase is a concern

FWIW this is what I did here for node stack traces: #14420 , it's similar to how the protocol does a DOM snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment