Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute LCP savings for render-blocking-resources #15240

Open
adamraine opened this issue Jul 10, 2023 · 1 comment
Open

Compute LCP savings for render-blocking-resources #15240

adamraine opened this issue Jul 10, 2023 · 1 comment
Assignees
@adamraine
Labels
needs-investigation P3

Comments

@adamraine
Copy link
Member

#15238 (comment)

render-blocking-resources computes savings using the FCP graph. In theory this savings estimate should be fine to use for LCP as well since render blocking resources are always loaded before FCP (i.e. none affect LCP and not FCP).

I do wonder how far this assumption goes, and if it's worth it to use the same calculation. Perhaps making a resource non-render blocking doesn't completely eliminate it's LCP impact.
@adamraine adamraine self-assigned this Jul 10, 2023
@paulirish
Copy link
Member

Related, we were looking at unused-js. Some of the items there can be are render-blocking. Others not.
But when we compute estimatedSavings for unused-js, we treat them uniformly. (Roughly, all network scripts are half- blocking (per lantern magic 🧙‍♀️ )
We could adjust this behavior to have more precision in the savings calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation P3
2 participants
@paulirish @adamraine