Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove devtoolsLogs and traces compat artifacts #15306

Open
3 of 6 tasks
adamraine opened this issue Jul 25, 2023 · 3 comments
Open
3 of 6 tasks

Remove devtoolsLogs and traces compat artifacts #15306

adamraine opened this issue Jul 25, 2023 · 3 comments
Assignees
@adamraine
Labels
breaking P2

Comments

@adamraine
Copy link
Member

adamraine commented Jul 25, 2023 •
edited
Loading

Carry-over from #15060
Initial pass: #15276

We are keeping these compat artifacts for 11.0 at least. We can potentially drop them in 12.0.

Non-breaking:

  • Remove all our usages of artifacts.devtoolsLogs and artifacts.traces
  • Ensure downstream users (e.g. pubads) remove usages of artifacts.devtoolsLogs and artifacts.traces
  • Update docs to reference new artifacts

Breaking:

  • Handle the error trace/dtlog differently
  • Remove defaultPass prefix from saved artifacts (i.e. defaultPass.trace.json -> trace.json)
  • Remove the compat artifacts devtools-log-compat and trace-compat
@adamraine adamraine self-assigned this Jul 25, 2023
@adamraine adamraine added the P2 label Jul 25, 2023
This was referenced Jul 26, 2023
Merged
Merged
Closed
This was referenced Aug 4, 2023
Merged
Closed
@connorjclark
Copy link
Collaborator

FYI #15843
@benschwarz
Copy link
Contributor

Am I correct in assuming that "compat artifacts" refers to the old API (which was kept for compatibility reasons), and artifacts.DevtoolsLog && artifacts.Trace will remain in place?
@adamraine
Copy link
Member Author

Am I correct in assuming that "compat artifacts" refers to the old API (which was kept for compatibility reasons), and artifacts.DevtoolsLog && artifacts.Trace will remain in place?

Yes
@adamraine adamraine removed this from the v12.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking P2
3 participants
@benschwarz @connorjclark @adamraine