Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentWidth audit doesn't measure content width #1836

Open
patrickhulce opened this issue Mar 8, 2017 · 2 comments
Open

ContentWidth audit doesn't measure content width #1836

patrickhulce opened this issue Mar 8, 2017 · 2 comments

Comments

@patrickhulce
Copy link
Collaborator

The current content-width audit was meant to be modeled after PSI's SizeContentToViewport check, but it fails to cover much of what it does. (Currently, it pretty much just checks that the meta viewport doesn't specify a width that's too small).

Ideally, this would be a full replacement for PSI's version that would check how much of the content requires horizontal scrolling.

@paulirish
Copy link
Member

@patrickhulce fixed by #1807 ?

@patrickhulce
Copy link
Collaborator Author

Nope wasn't fixed by that, just noticed there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants