-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit: Add JS coverage audit #1852
Comments
@patrickhulce is this something we can reignite? Is the protocol API in a good spot? Do you want to take it? Or I can if you prefer. |
not sure, the protocol hasn't really changed since the initial changes and we punted the CSS out, @paulirish any objections to bringing this in? might be trickier now though since last I checked enabling the tracking and noticeable perf impact and we're down to a single pass |
@ebidel just an update here after speaking with caseq, there's a potentially significant performance impact of enabling the coverage, so I'm going to investigate with some weak devices on plots and see how it impacts the numbers. I still have my local branch with the coverage fixes from way back, so its really a matter of ensuring we can continue as previously planned. |
Coolio. Even if new audits (like this) turn out to be slow, it would be beneficial for us to have them in the codebase for users to run. Maybe they're opt-in or something. |
Hi. @patrickhulce |
@patrickhulce is this live? I'm checking the extension and not seeing this audit in either pass/fail group. |
@rviscomi it's been living in the full-config for basically its entire life so you can only get it by using the CLI and manually passing in blocking item to move it into default is gathering data on how much of an impact turning on those debugger domains has on performance measurement |
Ahh ok. Is there an issue I can watch for the perf measurements? |
JS coverage has landed in the protocol and can be added as a similar byte efficiency audit to CSS usage.
The text was updated successfully, but these errors were encountered: