Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Add JS coverage audit #1852

Closed
patrickhulce opened this issue Mar 10, 2017 · 9 comments · Fixed by #3085
Closed

Audit: Add JS coverage audit #1852

patrickhulce opened this issue Mar 10, 2017 · 9 comments · Fixed by #3085
Assignees

Comments

@patrickhulce
Copy link
Collaborator

JS coverage has landed in the protocol and can be added as a similar byte efficiency audit to CSS usage.

@ebidel
Copy link
Contributor

ebidel commented Jun 5, 2017

@patrickhulce is this something we can reignite? Is the protocol API in a good spot?

Do you want to take it? Or I can if you prefer.

@patrickhulce
Copy link
Collaborator Author

not sure, the protocol hasn't really changed since the initial changes and we punted the CSS out, @paulirish any objections to bringing this in? might be trickier now though since last I checked enabling the tracking and noticeable perf impact and we're down to a single pass

@patrickhulce
Copy link
Collaborator Author

@ebidel just an update here after speaking with caseq, there's a potentially significant performance impact of enabling the coverage, so I'm going to investigate with some weak devices on plots and see how it impacts the numbers. I still have my local branch with the coverage fixes from way back, so its really a matter of ensuring we can continue as previously planned.

@ebidel
Copy link
Contributor

ebidel commented Jun 7, 2017

Coolio. Even if new audits (like this) turn out to be slow, it would be beneficial for us to have them in the codebase for users to run. Maybe they're opt-in or something.

@mixed
Copy link
Contributor

mixed commented Jul 19, 2017

Hi. @patrickhulce
I look forward to the completion of this work(CSS|JS coverage).🙏 Is this job currently stopped?

@patrickhulce
Copy link
Collaborator Author

@mixed yes currently blocked on review, the CSS coverage updates are in #2518 and I will rebase my local JS coverage against in once it's merged

@rviscomi
Copy link
Member

rviscomi commented Jan 9, 2018

@patrickhulce is this live? I'm checking the extension and not seeing this audit in either pass/fail group.

@patrickhulce
Copy link
Collaborator Author

@rviscomi it's been living in the full-config for basically its entire life so you can only get it by using the CLI and manually passing in --config-path=./lighthouse-core/config/full-config.js

blocking item to move it into default is gathering data on how much of an impact turning on those debugger domains has on performance measurement

@rviscomi
Copy link
Member

rviscomi commented Jan 9, 2018

Ahh ok. Is there an issue I can watch for the perf measurements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants