Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Uses inefficient cache policy on static assets" rule should group by path #5671

Open
tomayac opened this issue Jul 16, 2018 · 4 comments
Open

Comments

@tomayac
Copy link
Member

tomayac commented Jul 16, 2018

The current "Uses inefficient cache policy on static assets" list is not very actionable (excerpt of an actual audit):

screen shot 2018-07-16 at 12 09 44

Can Lighthouse try to group them by origin and path?

  • Oftentimes per-origin grouping already allows users to see if they can't change things (true third-party like securepubads.g.doubleclick.net) or if they in fact can do something about it (sharded third-party like cdn.example.com).
  • Based on that, per-path grouping then reveals common patterns (like cdn.example.com/assets has 30 days vs. cdn.example.com/static/icons has 24h).
@patrickhulce
Copy link
Collaborator

Thanks @tomayac! :)

We have discussed introducing a third party filter perhaps just a more generic origin filter could be helpful here.

@paulirish
Copy link
Member

IMO 3P badging or favicons could make this easier to deal with. cc #4516

@connorjclark
Copy link
Collaborator

What if we put all the items of the same origin in a single item, and used subItems for the actual resources?

@tomayac
Copy link
Member Author

tomayac commented Sep 30, 2022

I think this would work and is what I had in mind when I filed the Issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment