Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smoketests for lantern opportunities #7039

Open
patrickhulce opened this issue Jan 17, 2019 · 3 comments
Open

Add smoketests for lantern opportunities #7039

patrickhulce opened this issue Jan 17, 2019 · 3 comments
Labels
internals P2

Comments

@patrickhulce
Copy link
Collaborator

Summary
Currently our byte efficiency smoketests are based on devtools throttling, not lantern. We should be testing for both.

Note: Created from a TODO in code so it can be more visible and properly prioritized
@patrickhulce
Copy link
Collaborator Author

patrickhulce commented Jan 17, 2019 •
edited
Loading

Partially blocked on #5504 and #4600
@paulirish paulirish removed the testing label Jul 23, 2019
@patrickhulce
Copy link
Collaborator Author

Blocked on #4600, which is actually far more important than this.
@patrickhulce
Copy link
Collaborator Author

#4600 isn't solvable without Chromium tracing changes :/ As this was sitting for ~18 months as a P1.5 I'm gonna make the value judgement it's more of a P2.

If you disagree, then let's pick up the conversation about prioritizing #4600 over there :)
@patrickhulce patrickhulce added P2 and removed P1.5 labels Sep 21, 2020
@patrickhulce patrickhulce removed their assignment Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals P2
2 participants
@paulirish @patrickhulce