-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSUsage not finding all stylesheet content #8493
Comments
Based on the comments from #8534 (comment), it seems like this might be because DevTools just doesn't provide information on inline styles that don't have a |
If |
In the past I know some of those urls would just list the main page as the source. Similar to how everything that's dynamically added from an unattributable script is just listed as initiated by "parser". I'm not sure of the exact interplay here, but since it came up in your case, thought it might be the root cause here too. |
any update this issue ? styled-components ssr suffer this problem |
We are also seeing this using styled-components SSR on https://www.shopflamingo.com |
Also seeing this with Gatsby + styled-components: https://helloclue.com/articles/cycle-a-z/period-blood-color-brown-black-dark-does-it-matter (See the PageSpeed Insights report, which says |
I don't think we'll be getting this fixed in the protocol anytime in the immediate future so our best bet for now might be to ignore the fonts which we don't find a declaration for at all. |
@patrickhulce that could work, but does that match the behavior of Google's own page speed analysis for SEO purposes? If not, that would make this tool less accurate/useful. |
Well the opportunities themselves have no impact, it's just the performance metrics that are scored. We wouldn't be proactively suggesting ways for folks to improve their scores by ignoring fonts we aren't 100% sure about, but having folks spend time trying to figure out the bug here instead of working on other opportunities isn't a positive outcome. |
ah ! Gotcha — that makes sense. I had been under the impression that Lighthouse is itself used for Google's SEO performance metrics. |
Hey @patrickhulce, just wanted to check in — is this something that's on the roadmap to fix? |
I'll assign myself to the interim fix that will quiet the false positive, but the true fix requires Chromium-support and there is no timeline for a fix there. |
OK, gotcha. Thank you! |
Split out from #6628 (comment)
Provide the steps to reproduce
What is the current behavior?
LH reports that the fonts don't have font-display properties. The CSSUsage artifact does not contain the content of any of the stylesheets.
What is the expected behavior?
LH does not report the fonts are missing
font-display
, and the CSSUsage artifact contains the content of the stylesheets.Environment Information
The text was updated successfully, but these errors were encountered: