Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning when using ExpressRoutes w/wildcards in v2 #1011

Closed
jeffposnick opened this issue Nov 8, 2017 · 1 comment
Closed

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-routing

As discussed on Slack, we're unlikely to support ExpressRoute in v3 (at least not as part of workbox-routing). We will instead treat string paths passed in to registerRoute() as being exact matches against the path or full href of the incoming URL.

To pave the way for this new behavior, we should cut a new v2 patch release that adds in a log message explaining the upcoming change in v3. This message should be triggered whenever a developer creates a route using a string that has special meaning in ExpressRoute.

Based on https://github.com/pillarjs/path-to-regexp#parameters, the following characters should trigger the message:

  • :
  • ?
  • *
  • +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants