Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser transpilation target #1655

Closed
jeffposnick opened this issue Sep 21, 2018 · 0 comments
Closed

Update browser transpilation target #1655

jeffposnick opened this issue Sep 21, 2018 · 0 comments
Labels
Breaking Change Denotes a "major" semver change. Browser Compatibility Tied to service worker behavior in a specific browser. Infrastructure Related to the helper and utility scripts in the project.
Milestone
v4

Comments

@jeffposnick
Copy link
Contributor

jeffposnick commented Sep 21, 2018 •
edited
Loading

We currently use @babel/preset-env to transpile down to Chrome 51:

workbox/gulp-tasks/utils/rollup-helper.js

Lines 19 to 22 in 3612461

// This corresponds to the version of Chroumium used by
// Samsung Internet 5.x, which is the minimum non-evergreen browser
// we currently support.
browsers: ['chrome >= 51'],

This target was chosen to accommodate Samsung Internet 5.x.

As per https://developer.samsung.com/internet/android/releases, there have been two stable releases of Samsung Internet 6.x based on Chromium 56 (along with a beta 7.x release based on an even newer Chromium), so I think we can safely switch that to be the new transpilation target for Workbox v4.

CC: @poshaughnessy and @AdaRoseCannon from the Samsung Internet team as a heads-up, to see if there are any concerns about shifting to Chrome 56 as the transpilation target—I'm not sure how much of a market share Samsung Internet 5.x still has.
@jeffposnick jeffposnick added Infrastructure Related to the helper and utility scripts in the project. Breaking Change Denotes a "major" semver change. labels Sep 21, 2018
@jeffposnick jeffposnick added this to the v4 milestone Sep 21, 2018
@jeffposnick jeffposnick added the Browser Compatibility Tied to service worker behavior in a specific browser. label Sep 21, 2018
@jeffposnick jeffposnick mentioned this issue Sep 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Denotes a "major" semver change. Browser Compatibility Tied to service worker behavior in a specific browser. Infrastructure Related to the helper and utility scripts in the project.
2 participants
@philipwalton @jeffposnick