Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

AtariInputFilter is missing cropping to 84x84 after rescaling to 110x84 #186

Open
gal-leibovich opened this issue Jan 9, 2019 · 0 comments
Open

AtariInputFilter is missing cropping to 84x84 after rescaling to 110x84 #186

gal-leibovich opened this issue Jan 9, 2019 · 0 comments
Labels
priority/p2 questions needing answered or medium impact bugs
Projects
Coach Dev

Comments

@gal-leibovich
Copy link
Contributor

According to the original DQN paper, observation preprocessing should be done as -

The raw frames are preprocessed by first converting their RGB representation to gray-scale and down-sampling it to a 110×84 image. The final input representation is obtained by cropping an 84 × 84 region of the image that roughly captures the playing area.

Our AtariInputFilter, on the other hand, rescales directly to 84x84, without first rescaling to 110x84, and then finally cropping to 84x84.

Chances are this issue has a fairly low impact. Yet, it might have some small impact on Atari benchmark results.
@scttl scttl added this to To do in Coach Dev Jan 10, 2019
@galnov galnov moved this from To do to P2 in Coach Dev Jan 13, 2019
@scttl scttl added the priority/p2 questions needing answered or medium impact bugs label Jan 16, 2019
@scttl scttl moved this from P2 to Groomed but Not Started in Coach Dev Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/p2 questions needing answered or medium impact bugs
2 participants
@scttl @gal-leibovich