Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No #line directives generated when --target-env is vulkan1.1, vulkan1.2 or vulkan1.3 #3192

Open
TonyBarbour opened this issue Apr 18, 2023 · 3 comments
Labels

Comments

@TonyBarbour
Copy link

GPU-AV depends on #line directives to determine which source line is responsible for a validation error. glslang is generating #line directive(s) with --target-env vulkan1.0, but not vulkan1.1, 1.2, or 1.3. #line is also created when no --target-env is specified. Issue is at KhronosGroup/Vulkan-ValidationLayers#5596

@corporateshark
Copy link
Contributor

We have the same problem in LightweightVK when using glslang C-interface. No SPIR-V OpSource is generated when emit_nonsemantic_shader_debug_source is enabled.

https://github.com/corporateshark/lightweightvk/blob/d1c511d9bfaf8e96c0efa00a33b7bec5d1cd7e79/lvk/vulkan/VulkanUtils.cpp#L649

@arcady-lunarg
Copy link
Contributor

@corporateshark I think that is a somewhat different issue, could you open a new issue for your problem? Also, could you confirm that you're using the most recent version of glslang as there was a somewhat similar sounding bug that was fixed recently.

@spencer-lunarg
Copy link
Contributor

I am taking over the original VVL issue posted

I just tested with -g and it seems to display both OpLine/OpSource with all --target-env and I don't know if this is still an issue anymore or not (for glslang)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants