Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to correct qualified names to indexed access types #17462

Merged
merged 5 commits into from
Jul 27, 2017

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Jul 27, 2017

Fixes #17461

qnwithiat

@DanielRosenwasser DanielRosenwasser changed the title Code fix for error for property of type as type Jul 27, 2017
Copy link
Contributor

@aozgaa aozgaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you want to make changes to get the fix working in the case mentioned below, but please add a test.

const token = getTokenAtPosition(sourceFile, context.span.start, /*includeJsDocComment*/ false);
const qualifiedName = getAncestor(token, SyntaxKind.QualifiedName) as QualifiedName;
Debug.assert(!!qualifiedName, "Expected position to be owned by a qualified name.");
if (!isIdentifier(qualifiedName.left)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example doesn't seem to trigger the right error, though we can apply the fix manually to fix the issue:

module M {
    export interface I {
         foo: string;
    }
}
let a: M.I.foo;

Please add a test.

@@ -1,3 +1,4 @@
/// <reference path="correctQualifiedNameToIndexedAccessType.ts" />
/// <reference path="fixClassIncorrectlyImplementsInterface.ts" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an analogous entry to this in src/harness/tsconfig.json. Not sure why it's there, or if we might want to remove it. Or alternatively, add a reference to correctQualifiedNameToIndexedAccessType.ts.

@weswigham do you know if building for tests will correctly trigger a rebuild when we make changes to correctQualifiedNameToIndexedAccessType.ts?

@DanielRosenwasser
Copy link
Member Author

@aozgaa no, I didn't generalize the check, but I can at a later point. I did add a negative fourslash test, and augmented the tests added in #17459.

…e already referenced in 'src/harness/codefixes/fixes.ts'.
@DanielRosenwasser DanielRosenwasser merged commit 6565025 into master Jul 27, 2017
@DanielRosenwasser DanielRosenwasser deleted the codeFixForErrorForPropertyOfTypeAsType branch July 27, 2017 22:32
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants