Add support for configuration inheritance via packages #27348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
rbuckton,
RyanCavanaugh,
sheetalkamat and
a user
sheetalkamat
reviewed
Oct 1, 2018
src/compiler/commandLineParser.ts
Outdated
| return extendedConfigPath; | ||
| } | ||
| // If the path isn't a rooted or relative path, resolve like a module | ||
| const resolved = nodeModuleNameResolver(extendedConfig, combinePaths(basePath, "tsconfig.json"), { moduleResolution: ModuleResolutionKind.NodeJs }, host, /*cache*/ undefined, /*lookupConfig*/ true); |
There was a problem hiding this comment.
There is no way to traceResolution this. Ideally we would want to flow that option here (esp when invoked from command prompt)? To ensure users are able to find out whats going on when resolving tsconfig.json?
|
Ping @sheetalkamat I wired through tracing; anything else? |
sheetalkamat
approved these changes
Oct 23, 2018
|
I'm thrilled. Where can I see the documentation for this, please? |
|
Awesome! Hope to see this in the next release!!! :D |
sebald
added a commit
to sebald/unscripted
that referenced
this pull request
Feb 22, 2019
See for more information microsoft/TypeScript#27348
evocateur
added a commit
to evocateur/load-tsconfig
that referenced
this pull request
May 16, 2022
evocateur
added a commit
to evocateur/load-tsconfig
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18865