Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error is thrown when empty parent tile is in frustum but children are not #94

Closed
gkjohnson opened this issue Jul 13, 2020 · 0 comments · Fixed by #99 or #101
Closed

Error is thrown when empty parent tile is in frustum but children are not #94

gkjohnson opened this issue Jul 13, 2020 · 0 comments · Fixed by #99 or #101
Labels
bug Something isn't working

Comments

@gkjohnson
Copy link
Contributor

  1. Load a tileset with a parent tile that has no content.
  2. Move camera such that the children are out of the frustum but the parent bounds are within the frustum.
  3. Parent tile tries to be loaded despite not having content and throws an error.

The problematic code block is here.

This case is addressed in other cases here and here by checking if the tile has content before loading it.
@gkjohnson gkjohnson added the bug Something isn't working label Jul 13, 2020
@gkjohnson gkjohnson changed the title When only empty parent tile is in frustum but children are not Jul 13, 2020
@gkjohnson gkjohnson added this to the v0.1.4 milestone Jul 13, 2020
@gkjohnson gkjohnson mentioned this issue Jul 14, 2020
Merged
3 tasks
@gkjohnson gkjohnson mentioned this issue Jul 14, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant
@gkjohnson