Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Sign in/up width card and fields #236

Open
meridorkobi opened this issue Aug 29, 2021 · 2 comments
Open

[FEATURE] Sign in/up width card and fields #236

meridorkobi opened this issue Aug 29, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@meridorkobi
Copy link

Can we Define / increase the width for long eMail or name ?

@meridorkobi meridorkobi added the enhancement New feature or request label Aug 29, 2021
@fedepell
Copy link
Contributor

fedepell commented Sep 1, 2021

As far as I see currently they are hardcoded and:

    final cardWidth = min(deviceSize.width * 0.75, 360.0);
    const cardPadding = 16.0;
    final textFieldWidth = cardWidth - cardPadding * 2;

So the card width is 75% of the screen (or 360 for big screens) and then the text fields are based on that minus the padding.

It may be feasible to improve that we can pass that (I'd say just cardWidth, leaving the others calculated from that) in case, but not sure how many users could use that (as 75% sounds quite reasonable). It would require a couple of info passages (FlutterLogin -> AuthCard -> Login/Signup/Recover cards)

@juliansteenbakker would you see this as an useful improvement?

@juliansteenbakker
Copy link
Collaborator

Sorry for the late response. I think it can be possible just as long as it doesn't mess with the animations.

I'm open for a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants