Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] IMP l10n_it_account showing which accounts have wrong sign #2159

Merged
merged 1 commit into from
Mar 29, 2021
Merged

[12.0] IMP l10n_it_account showing which accounts have wrong sign #2159

merged 1 commit into from
Mar 29, 2021

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Mar 8, 2021

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing
mrcast
mrcast approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK!
@eLBati
Copy link
Member Author

eLBati commented Mar 16, 2021

Sarà poi da fare anche per 14.0
SilvioGregorini
SilvioGregorini approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@SilvioGregorini SilvioGregorini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'unico appunto che mi viene in mente è che si potrebbe rinominare il metodo get_incoherent_sign_accounts in group_accounts_per_sign visto che è quello che, nei fatti, viene eseguito 😄 ma è banale nomenclatura
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@sergiocorato
Copy link
Contributor

/ocabot merge patch
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-2159-by-sergiocorato-bump-patch, awaiting test results.
@OCA-git-bot OCA-git-bot merged commit 337262e into OCA:12.0 Mar 29, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 25e72ec. Thanks a lot for contributing to OCA. ❤️
@eLBati eLBati mentioned this pull request Mar 30, 2021
Open
3 tasks
@francesco-ooops francesco-ooops linked an issue Dec 21, 2023 that may be closed by this pull request
IMP l10n_it_account showing which accounts have wrong sign #2192
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 ready to merge
5 participants
@eLBati @OCA-git-bot @sergiocorato @mrcast @SilvioGregorini